[GitHub] [kafka] kirktrue commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-10 Thread via GitHub
kirktrue commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190226530 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long

[GitHub] [kafka] kirktrue commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-05-10 Thread via GitHub
kirktrue commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190210077 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1132,6 +1136,7 @@ public void onSuccess(Void value) {