[GitHub] [kafka] kkonstantine commented on pull request #11933: KAFKA-13759: Disable idempotence by default in producers instantiated by Connect

2022-03-23 Thread GitBox
kkonstantine commented on pull request #11933: URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076884660 Thanks @rhauch. The fix has now been merged to trunk and cherry picked to 3.2, 3.1 and 3.0 with the appropriate adjustments to the upgrade notes. cc @cadonna @tombentley

[GitHub] [kafka] kkonstantine commented on pull request #11933: KAFKA-13759: Disable idempotence by default in producers instantiated by Connect

2022-03-23 Thread GitBox
kkonstantine commented on pull request #11933: URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076781304 Thanks @rhauch. I've incorporated your suggestions in all places. The PR is ready for another pass -- This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] kkonstantine commented on pull request #11933: KAFKA-13759: Disable idempotence by default in producers instantiated by Connect

2022-03-23 Thread GitBox
kkonstantine commented on pull request #11933: URL: https://github.com/apache/kafka/pull/11933#issuecomment-1076612664 Tests passed on the latest run with a couple of failures that don't seem relevant. Yet, because one failure was on `SourceConnectorsIntegrationTest` I'm rerunning these te