[GitHub] [kafka] kowshik commented on a change in pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

2021-04-25 Thread GitBox
kowshik commented on a change in pull request #10592: URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala ## @@ -35,6 +39,17 @@ class LogSegmentsTest { LogTestUtils.createSegment(offse

[GitHub] [kafka] kowshik commented on a change in pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

2021-04-24 Thread GitBox
kowshik commented on a change in pull request #10592: URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala ## @@ -35,6 +39,17 @@ class LogSegmentsTest { LogTestUtils.createSegment(offse

[GitHub] [kafka] kowshik commented on a change in pull request #10592: MINOR: Remove redudant test files and close LogSegment after test

2021-04-24 Thread GitBox
kowshik commented on a change in pull request #10592: URL: https://github.com/apache/kafka/pull/10592#discussion_r619682506 ## File path: core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala ## @@ -35,6 +39,17 @@ class LogSegmentsTest { LogTestUtils.createSegment(offse