[GitHub] [kafka] kowshik commented on pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-30 Thread GitBox
kowshik commented on pull request #10401: URL: https://github.com/apache/kafka/pull/10401#issuecomment-810028238 @junrao The jenkins tests have finished. I checked the test failures, they seem to be unrelated to this PR: ``` kafka.server.RaftClusterTest.testCreateClusterAndCreateL

[GitHub] [kafka] kowshik commented on pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-29 Thread GitBox
kowshik commented on pull request #10401: URL: https://github.com/apache/kafka/pull/10401#issuecomment-809804016 @junrao The rebase has started Jenkins run now. We can wait for the tests to pass. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] kowshik commented on pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-29 Thread GitBox
kowshik commented on pull request #10401: URL: https://github.com/apache/kafka/pull/10401#issuecomment-809799574 @junrao It seems to have just started building at `23:47` UTC time i.e. ~5m ago: https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-10430/2/pipel

[GitHub] [kafka] kowshik commented on pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-29 Thread GitBox
kowshik commented on pull request #10401: URL: https://github.com/apache/kafka/pull/10401#issuecomment-809617378 Thanks for the review @junrao ! I've addressed the review comment(s) in 8f1e292 and 4d73714. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] kowshik commented on pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-25 Thread GitBox
kowshik commented on pull request #10401: URL: https://github.com/apache/kafka/pull/10401#issuecomment-806446720 @junrao, @dhruvilshah3 - this PR is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th