[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-20 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-823441394 I checked the failed tests in CI this morning and none of them are related with this PR: ``` org.apache.kafka.connect.*

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-20 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-823118678 Thanks for the review @junrao and @satishd! I've updated this PR after rebasing onto latest commit in trunk. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-16 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-821333025 @junrao: Thanks for the review! I have addressed the latest comments and also fixed the broken `PartitionLockTest` test. This PR is ready for review. -- This is an automated

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-12 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-817634015 @junrao @satishd: Thanks for the review! I've responded to your comments and addressed them in 8f068caa78a9998c14a18f4583eaaa8a90cba71c. -- This is an automated message from

[GitHub] [kafka] kowshik commented on pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-07 Thread GitBox
kowshik commented on pull request #10478: URL: https://github.com/apache/kafka/pull/10478#issuecomment-815353566 cc @dhruvilshah3 @junrao @satishd -- this PR is ready for a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to