[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-16 Thread GitBox
kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-710503810 @junrao Thank you for the review! I've address the comments and the PR is ready for review again. This is an auto

[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-14 Thread GitBox
kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-708609368 @abbccdda Thanks for the review! I've addressed the most recent comment. This is an automated message from the Apa

[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-708070565 > one thing to point out is that we need to look at the KIP-584 definition for the basic tool usage and make sure the API names are aligned. This is done now. Please refer t

[GitHub] [kafka] kowshik commented on pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-11 Thread GitBox
kowshik commented on pull request #9409: URL: https://github.com/apache/kafka/pull/9409#issuecomment-706762993 @abbccdda @junrao : This PR is ready for review. This is an automated message from the Apache Git Service. To res