[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r567013228 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def Integer:

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r566957547 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache So

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r566957204 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -41,8 +43,19 @@ object Serdes { implicit def Integer:

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r564906839 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache So

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r564906839 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache So

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r564881288 ## File path: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/SerdesUnitTest.scala ## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache So

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562709184 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializerTest.java ## @@ -56,4 +57,23 @@ public void testWindowedValueDes

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562699939 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -235,25 +235,27 @@ public void shouldRe

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562698730 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -327,7 +329,7 @@ public void shouldAggr

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562056000 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializer.java ## @@ -61,6 +61,21 @@ public Long getWindowSize() { @

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562156019 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializer.java ## @@ -33,22 +33,22 @@ */ public class TimeWindowedDese

[GitHub] [kafka] lct45 commented on a change in pull request #9253: KAFKA-10366 & KAFKA-9649: Implement KIP-659 to allow TimeWindowedDeserializer and TimeWindowedSerde to handle window size

lct45 commented on a change in pull request #9253: URL: https://github.com/apache/kafka/pull/9253#discussion_r562056000 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedDeserializer.java ## @@ -61,6 +61,21 @@ public Long getWindowSize() { @