[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-18 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1329165007 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -361,6 +364,84 @@ public void testWakeup_committed() {

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327848517 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerUtils.java: ## @@ -141,4 +146,53 @@ public static List> configuredConsumerIntercept

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327788743 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327784079 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners

[GitHub] [kafka] lianetm commented on a diff in pull request #14385: KAFKA-15306 - Integrating committed offsets for updating fetch positions

2023-09-15 Thread via GitHub
lianetm commented on code in PR #14385: URL: https://github.com/apache/kafka/pull/14385#discussion_r1327771100 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -667,6 +683,35 @@ private static ClusterResourceListeners