[GitHub] [kafka] lihaosky commented on a diff in pull request #12944: [KAFKA-14395] add config to configure client supplier

2022-12-07 Thread GitBox
lihaosky commented on code in PR #12944: URL: https://github.com/apache/kafka/pull/12944#discussion_r1042544360 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -1076,7 +1082,12 @@ public class StreamsConfig extends AbstractConfig {

[GitHub] [kafka] lihaosky commented on a diff in pull request #12944: [KAFKA-14395] add config to configure client supplier

2022-12-05 Thread GitBox
lihaosky commented on code in PR #12944: URL: https://github.com/apache/kafka/pull/12944#discussion_r1040472261 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -1088,6 +1088,28 @@ public void shouldTriggerRecordingOfRocksDBMetricsIfRecordingLevelI