lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1056940382
Hi @cadonna , thanks for the review.
I agree with what you said and made a note to myself to address your
comments in the follow-up PRs. So if it's okay, I think we can
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1055489018
Thanks @cadonna, appreciate it.
@showuon please also note that next PR, the protocol change, is also ready
to be reviewed. https://github.com/apache/kafka/pull/10802
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1050043629
Hi @cadonna
Mind having another look? Hoping to finalise this PR as soon as possible :)
Thanks
--
This is an automated message from the Apache Git Service.
To
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1048612254
Hi @cadonna @showuon
I've addressed your comments. Please have a look.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1046758399
Thanks @showuon for the valuable feedback.
I've addressed your comments, please have a look when you got time.
--
This is an automated message from the Apache Git
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1044574529
Hi @showuon Thanks for the feedback.
I've addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1041380775
Hi @showuon, @cadonna
Thanks for the valuable feedback. I've addressed your comments and pushed
the changes. I also resolved conversations feel free to unresolve
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1025503003
Hi @cadonna ,
Sorry for the ping. Any chance we could review PR this week?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1018535614
The latest commit (be3dcff4dc463fd8d23998537e36f852b99ec083) has a few
changes.
1. There's explicit fallback to fallback to `DefaultStandbyTaskAssignor`
logic if
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1017815908
Hi @cadonna,
I've address your comments with the latest commit.
Please have a look when you got time.
Thanks.
--
This is an automated message from the Apache
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-1017438641
Hi @cadonna small update from my side.
I cam back from holidays a week ago so will continue working on this PR this
week.
Sorry for the delay.
--
This is an
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-993399413
Hi @cadonna thanks for the feedback.
I'll address your comments shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-984477740
@cadonna no worries and thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-983959899
Hi @cadonna ,
Will you have time to look at this PR again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-959050366
Hi @cadonna
Very sorry for disappearing, didn't find time to deal with this PR.
I've addressed your comments. Please have another look when you got time.
--
This is
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-959050366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-959050366
Hi @cadonna
Very sorry for disappearing, didn't find time to deal with this PR.
I've addressed your comments. Please have another look when you got time.
--
This is
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-944314838
Hi @cadonna,
Small update on my side - wasn't able to find time to work on this PR this
week.
Will try to prioritise this for the next week.
--
This is an automated
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-934149747
Thanks for the feedback @cadonna
I will review and address your comments this week.
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-925659295
Hi @cadonna is it possible to continue pushing this PR forward? I'm back
from my holidays.
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-911752624
Hi @cadonna,
I've addressed/replied to your comments. Thanks for the feedback.
FYI - I'll be offline from next week for 2 weeks.
--
This is an automated message from
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160
The general thought on the implementation.
As of now, we choose concrete `StandbyTaskAssignor` implementation based on
passed `AssignmentConfigs` value.
Instead, an
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-905490438
Thanks for the feedback @cadonna , I've pushed the new changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-902900779
Hi @cadonna
Thank you for valuable feedback.
I've addressed your comments. Please have a look once you got time.
--
This is an automated message from the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-899245208
Hi @cadonna !
Thanks for the feedback. I will address your comments this week.
--
This is an automated message from the Apache Git Service.
To respond to the message,
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-882283484
Thanks @cadonna for the valuable feedback
I've replied/addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-880127165
Thanks @cadonna for the feedback.
I've replied/addressed all of your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message,
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-862166415
gentle nudge @cadonna @vvcephei @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-857564039
Call for review @cadonna @vvcephei @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
29 matches
Mail list logo
