[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018951885 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -250,30 +261,31 @@ private void removeUpdatingAndPausedTasks() {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018903133 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -121,21 +121,32 @@ private void runOnce() throws

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-10 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1018881878 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -250,30 +261,31 @@ private void removeUpdatingAndPausedTasks() {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-09 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1017943192 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -277,6 +294,9 @@ private void addTask(final Task task) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-08 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1016657641 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1908,6 +1888,7 @@ public void

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-08 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1016657214 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -277,6 +294,9 @@ private void addTask(final Task task) {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12795: KAFKA-14299: Initialize tasks in state updater

2022-11-08 Thread GitBox
lucasbru commented on code in PR #12795: URL: https://github.com/apache/kafka/pull/12795#discussion_r1016644371 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -115,6 +117,7 @@ public void run() { private void