[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282671259 There are some errors related to missing state again. But again, it doesn't look related. Can we merge it? ``` Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282186142 Right, sorry, I misread your comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-18 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1282151422 Makes sense. So @cadonna can we please merge this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-17 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1281213000 Failures look largely unrelated. However, `SmokeTestDriverIntegrationTest` fails - so since this code path wasn't modified here, it looks like it is already flaky in `trunk`. -- This

[GitHub] [kafka] lucasbru commented on pull request #12749: KAFKA-14299: Fix busy polling with separate state restoration

2022-10-14 Thread GitBox
lucasbru commented on PR #12749: URL: https://github.com/apache/kafka/pull/12749#issuecomment-1279148211 @guozhangwang @cadonna Do you want to have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL