[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598817722 > @machi1990 , could you explain more about this: > > > The test neither calls commitSync, nor commitAsync which means that the cache is never updated in [2] after initially set

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598653771 > @showuon I was looking onto this and after several local runs, I managed to eliminate some flasky test and came up with the list of failures that are only caused by this change. The

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1597260242 @showuon I was looking onto this and after several local runs, I managed to eliminate some flasky test and came up with the list of failures that are only caused by this change. The

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1596813632 > @machi1990 , looks like this change breaks some tests. Could you take a look? > > https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13665/12 Thank you @showuon

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1592956695 > LGTM! Just one minor comment. After addressing it, I'll check the CI build result tomorrow. Thank you for the patch! Thank you so much for the review and help on this @showuon

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1592934743 Thanks @showuon for your review on this. I've addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1592771368 > @machi1990 , thanks for the update, left some more comments. Thanks for the thorough review @showuon I've addressed all the comments. Please have another look when you've some

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1586703079 Hey @showuon the PR should be ready for another round of review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1567839961 > Overall LGTM. Could we add tests to verify the committed offsets cache will be updated when the consumer committed some offests? Also, you could change to "non-draft" state when

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1554132616 Thank you for the review @showuon I'll address the comments by pushing code change in the next while. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1547431713 > I'll try to have a look this week. Thanks. Thanks @showuon I appreciate it. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] machi1990 commented on pull request #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1542514663 @ableegoldman @showuon can you've a look at this draft PR once you've sometime? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please