[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-09-17 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1250062919 Scala 2.12.17 just came out so I have rebased the PR with the new Scala version. This also means that all of the qualms mentioned in

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-09-12 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1243496402 @ijuma @mimaison Any chance of a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-08-18 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219328536 @mimaison > Can you also update bin/kafka-run-class.sh and bin/windows/kafka-run-class.bat? I just checked those files and it seems that this is not necessary because we

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-06-17 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1158708791 > Yes, kafka is unaffacted by it now, but it could be affected in the future. The fix for this has already been merged into Scala and it will be included in the 2.12.17

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-06-15 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156984238 > Is there something you're looking for in 2.12.16? So I already had a detailed look into this, it only occurs at compile time (see

[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16

2022-06-15 Thread GitBox
mdedetrich commented on PR #12284: URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156251953 @divijvaidya Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.