michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-883778218
Awesome. Thanks @rhauch !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-871152067
Did you have any further comments on this @rhauch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-811661662
Thanks for having a look at this @rhauch . I've updated with the suggested
log messages, and reordered the methods and lines in the
ConnectorStatusListener.
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-697142928
Hey @C0urante, I'm not sure how long it usually takes for a committer to get
around to looking at things like this, maybe several months is normal, but just
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-677909122
What do you think @kkonstantine ? Is this something you could look at?
This is an automated
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-660778556
Perhaps it's something you could look at @mjsax ?
This is an automated message from the Apache
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-655189921
Perhaps this is something you would be interested in @rhauch ?
This is an automated message
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-649884360
Is this something you'd be willing to look at @gwenshap ?
(Apologies if this isn't of interest to you, I'm not very familiar with
which committer would be
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-649196880
I've made changes to those test now @C0urante . I couple of things worth
noting: Changing the mock of the WorkMetricsGroup to a real object needs a fair
few
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-648002707
OK, I've made the changes that we discussed.
This is an automated message from the Apache Git
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-647356784
Thanks for reviewing this @C0urante.
"if the framework successfully instantiates a connector and is able to call
start on it, should that alone qualify
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-647205060
Is this something you could review @C0urante ?
This is an automated message from the Apache
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-645688407
retest this please
This is an automated message from the Apache Git Service.
To respond to the
michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-63698
Failing unit test
kafka.admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles is unrelated
to this pull request and is tracked by:
14 matches
Mail list logo
