[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-14 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1022018101 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -77,20 +79,23 @@ public void testReplicationConfigProperties() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-14 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1021676801 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -16,23 +16,37 @@ */ package org.apache.kafka.connect.mirror; +import org.a

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-11-02 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1012087744 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-28 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008070254 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-28 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007859820 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-27 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007096564 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/clients/admin/FakeForwardingAdminWithLocalMetadata.java: ## @@ -0,0 +1,117 @@ +package org.apache.kafka

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

2022-10-13 Thread GitBox
mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r994551128 ## clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or