mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1642274928
My point is that this really contradicts the KIP. In the KIP we say "it does
not work" but then we have a test that relies on the upgrade working. This is a
bit counter intuitive.
--
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1623903798
Also we need to update the `LICENSE-binary` file as mentioned in
https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L73-L74
--
This is an automated message from the
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1622020208
I'm not familiar with these tests so please correct me if I'm not
understanding something correctly.
First, the KIP states (Compatibility, Deprecation, and Migration Plan
section)
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1599080971
I've not setup the system tests recently. If the provided instructions are
not clear enough, let's discuss it on the dev mailing list. You can also open
Jiras for the issues you encounte
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1576955162
Thanks @clolov for the PR. I think some system tests do upgrades from
previous versions to the latest. Have you checked these system tests still work
with this change?
--
This is an a