mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-635878906
Thanks @hachikuji. I've pushed another update addressing your comments.
I also sent an update to the thread on the mailing list.
--
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-635604107
@hachikuji Thanks for the feedback. I've pushed updates addressing your
comments.
I've also updated the KIP accordingly and I'll send a message to the VOTE
thread on the m
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-634249266
@hachikuji Yes I think it's better this way. I'll update the KIP
This is an automated message from the Apache Git
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-632591659
Thanks @hachikuji for the feedback. You brought some interesting points that
overall simplify the KIP/logic a bit.
While initially, it seemed a perfect use case for tagged fie
mimaison commented on pull request #8238:
URL: https://github.com/apache/kafka/pull/8238#issuecomment-622140465
Thanks @dajac for the great feedback! I believe I've addressed all your
comments now.
@cmccabe @rajinisivaram As you voted on the KIP, could you take a look?
