[GitHub] [kafka] mimaison commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-09 Thread GitBox
mimaison commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-742106800 @ning2008wisc There are a few checkstyle failures: ``` > Task :connect:runtime:checkstyleTest [ant:checkstyle] [ERROR]

[GitHub] [kafka] mimaison commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-11-19 Thread GitBox
mimaison commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-730467364 > If we have to control the complexity, I would prefer to drop testWithBrokerRestart and keep MirrorConnectorsIntegrationSSLTest, as it makes sense to run simple validation in

[GitHub] [kafka] mimaison commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-11-09 Thread GitBox
mimaison commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-724323408 @ning2008wisc I've not forgotten this PR, I just haven't had time to do reviews yet :( This is an automated

[GitHub] [kafka] mimaison commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-10-30 Thread GitBox
mimaison commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-719446426 @ning2008wisc Thanks for the quick update. It's still on my todo list but unfortunately I don't have time to do reviews this week. I hope to take another look next week.