[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r620479940 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java ## @@ -402,6 +402,11 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r619899204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final K

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r618760487 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -219,11 +224,19 @@ public V putIfAbsent(final

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r617136596 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java ## @@ -73,6 +76,7 @@ public boolean

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r615007673 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -326,6 +326,7 @@ public void putAll(final List>