[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430753853 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCode(

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429500010 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCode(

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499887 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuateSystemT

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499839 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuateSystemT

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-22 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE