[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-22 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458965799 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -299,7 +318,17 @@ private void restoreStat

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458483259 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -612,72 +617,521 @@ public boolean loc

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458483023 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -612,72 +617,521 @@ public boolean loc

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458482846 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -612,72 +617,521 @@ public boolean loc

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458482803 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -131,11 +135,40 @@ public void setGlobalPr

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458482408 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -612,72 +617,521 @@ public boolean loc

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458482045 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -58,30 +60,33 @@ * of Global State Store

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481794 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/RetryableErrorException.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481626 ## File path: docs/upgrade.html ## @@ -23,8 +23,8 @@ Notable changes in 2 The configuration parameter retries is deprecated for the producer, admin, a

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481521 ## File path: docs/streams/upgrade-guide.html ## @@ -95,11 +95,12 @@ Streams API -The configuration parameter retries is deprecated in

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481381 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms Low

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481315 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -308,15 +308,10 @@ bootstrap.serversThe replication factor for changelog topics and repa

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r458481231 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -203,7 +203,7 @@ bootstrap.serverscommit.interval.ms Low -The fr

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: remove `retries` for global tasks

2020-07-21 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r457889242 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -523,6 +524,8 @@ public static final String STATE_DIR_CONFIG = "sta