[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1095367325 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentsTest.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1095365120 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1093764504 ## streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #13143: KAFKA-14491: [3/N] Add logical key value segments

mjsax commented on code in PR #13143: URL: https://github.com/apache/kafka/pull/13143#discussion_r1084834388 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -0,0 +1,297 @@ +/* + * Licensed to the Apache Software Foundation (AS