[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282569306 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -715,23 +1087,49 @@ private Map>>

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282569306 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -715,23 +1087,49 @@ private Map>>

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282568706 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -715,23 +1087,49 @@ private Map>>

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -678,18 +838,230 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -678,18 +838,230 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-02 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -678,18 +838,230 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

2023-08-01 Thread via GitHub
mjsax commented on code in PR #14108: URL: https://github.com/apache/kafka/pull/14108#discussion_r1281300901 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java: ## @@ -156,6 +163,38 @@ public boolean