[GitHub] [kafka] mjsax commented on pull request #10207: Fixing documentation source for issue KAFKA-12360

2021-07-26 Thread GitBox
mjsax commented on pull request #10207: URL: https://github.com/apache/kafka/pull/10207#issuecomment-887104113 Closing this PR due to inactivity. @nicodds Feel free to re-open if you see fit. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] mjsax commented on pull request #10207: Fixing documentation source for issue KAFKA-12360

2021-03-03 Thread GitBox
mjsax commented on pull request #10207: URL: https://github.com/apache/kafka/pull/10207#issuecomment-789936874 @nicodds -- Thinking about this again, I am actually wondering why the value must be smaller then `max.poll.interval.ms` ? If a tasks idles, we should will call `poll()` frequentl

[GitHub] [kafka] mjsax commented on pull request #10207: Fixing documentation source for issue KAFKA-12360

2021-02-25 Thread GitBox
mjsax commented on pull request #10207: URL: https://github.com/apache/kafka/pull/10207#issuecomment-786280723 Thanks @nicodds! This PR should also update https://github.com/apache/kafka/blob/trunk/docs/streams/developer-guide/config-streams.html#L245-L246 -