[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-678457711 Thanks for the patch @serjchebotarev! Merged to `trunk`. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-670689958 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-660278609 Some follow up nits: The method `add10InputElements` does not throw any exception and we should remove the `throws` statement. Also in `AbstractResetIntegrationTest` in L283 we use

[GitHub] [kafka] mjsax commented on pull request #9028: KAFKA-10035: Safer conversion of consumer timeout parameters

mjsax commented on pull request #9028: URL: https://github.com/apache/kafka/pull/9028#issuecomment-659095839 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log