[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

2020-10-20 Thread GitBox
mjsax commented on pull request #9432: URL: https://github.com/apache/kafka/pull/9432#issuecomment-713023808 Well, that are timeout related: they checked if we send the shut-down signal. After the change, they should check if the `TimeoutException` is thrown and only kills the local

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

2020-10-15 Thread GitBox
mjsax commented on pull request #9432: URL: https://github.com/apache/kafka/pull/9432#issuecomment-709635418 Follow up PR: https://github.com/apache/kafka/pull/9446 This is an automated message from the Apache Git Service.

[GitHub] [kafka] mjsax commented on pull request #9432: KAFKA-10559: Not letting TimeoutException shutdown the app during internal topic validation

2020-10-15 Thread GitBox
mjsax commented on pull request #9432: URL: https://github.com/apache/kafka/pull/9432#issuecomment-709619232 Thanks for the PR @vamossagar12! No ideal to just remove the test instead of adjusting them, but we can do this in a follow up PR. @ableegoldman told me she will take care of