mumrah commented on code in PR #12565:
URL: https://github.com/apache/kafka/pull/12565#discussion_r956585846
##########
metadata/src/main/java/org/apache/kafka/metadata/util/BatchFileWriter.java:
##########
@@ -36,16 +39,24 @@
/**
- * Write an arbitrary set of metadata records into a Kafka metadata log batch
format. This is similar to the binary
- * format used for metadata snapshot files, but the log epoch and initial
offset are set to zero.
+ * Write an arbitrary set of metadata records into a Kafka metadata log batch
format.
+ *
+ * This is similar to the binary format used for metadata snapshot files, but
the log epoch
+ * and initial offset are set to zero.
Review Comment:
We should document that this class adds the two control records automatically
##########
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java:
##########
@@ -260,18 +260,18 @@ private void appendControlMessage(Function<ByteBuffer,
MemoryRecords> valueCreat
/**
* Append a {@link LeaderChangeMessage} record to the batch
*
- * @param @LeaderChangeMessage The message to append
- * @param @currentTimeMs The timestamp of message generation
+ * @param LeaderChangeMessage The message to append
+ * @param currentTimestamp The current time
Review Comment:
nit "current time in millis" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
