[GitHub] [kafka] ncliang commented on a change in pull request #10475: KAFKA-12610: Implement PluginClassLoader::getResource

2021-04-30 Thread GitBox
ncliang commented on a change in pull request #10475: URL: https://github.com/apache/kafka/pull/10475#discussion_r623622054 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java ## @@ -98,22 +97,56 @@ * to load internal

[GitHub] [kafka] ncliang commented on a change in pull request #10475: KAFKA-12610: Implement PluginClassLoader::getResource

2021-04-06 Thread GitBox
ncliang commented on a change in pull request #10475: URL: https://github.com/apache/kafka/pull/10475#discussion_r608251616 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java ## @@ -61,12 +61,24 @@ public Plugins(Map props) {

[GitHub] [kafka] ncliang commented on a change in pull request #10475: KAFKA-12610: Implement PluginClassLoader::getResource

2021-04-06 Thread GitBox
ncliang commented on a change in pull request #10475: URL: https://github.com/apache/kafka/pull/10475#discussion_r608245568 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java ## @@ -61,12 +61,24 @@ public Plugins(Map props) {

[GitHub] [kafka] ncliang commented on a change in pull request #10475: KAFKA-12610: Implement PluginClassLoader::getResource

2021-04-05 Thread GitBox
ncliang commented on a change in pull request #10475: URL: https://github.com/apache/kafka/pull/10475#discussion_r607232615 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java ## @@ -342,6 +343,47 @@ public void