[GitHub] [kafka] ncliang commented on a change in pull request #10563: KAFKA-12487: Add support for cooperative consumer protocol with sink connectors

2021-04-30 Thread GitBox
ncliang commented on a change in pull request #10563: URL: https://github.com/apache/kafka/pull/10563#discussion_r624411177 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -631,13 +648,31 @@ private void rewind() { }

[GitHub] [kafka] ncliang commented on a change in pull request #10563: KAFKA-12487: Add support for cooperative consumer protocol with sink connectors

2021-04-29 Thread GitBox
ncliang commented on a change in pull request #10563: URL: https://github.com/apache/kafka/pull/10563#discussion_r622851011 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -631,13 +648,31 @@ private void rewind() { }