ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-664045085
Hi @showuon thanks for your work, a minor thing - do you mind to consolidate
/ merge the current 4 commits into 1 commit?
--
ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-663147296
totally agree that it may be better to revisit the tests in MM2 and I
created a ticket https://issues.apache.org/jira/browse/KAFKA-10304 and assign
it to myself.
-
ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-661219342
Probably @mimaison could take the final review and approve it. Thanks
This is an automated message from the A
ning2008wisc commented on pull request #9029:
URL: https://github.com/apache/kafka/pull/9029#issuecomment-659516303
He @showuon thanks for the fix, it looks a good start. Another minor and
non-blocking comment may be: if it is a small fix, probably 1 commit in the PR
looks more neat.
---
