nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1647397496
@mimaison I resumed work on this PR to rewrite `ReassignPartitionsCommand`
in one change so if you have any preferences regarding splitting work into
several changes, please, write me :)
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1645993319
@mimaison Thanks for the review. I will address your comments in the nearest
time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1641385324
Tests failures seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1629267033
@fvaleri Can you, please, share you opinion? What is the next steps on
rewriting `ReassignPartitionsCommand`?
I can continue rewriting in this PR or there is committer that will commit
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1627732688
Hello, @fvaleri thanks for the review.
1. trunk merge to PR
2. all your comments fixed.
I'm ready to continue and finish work on moving `ReassignPartitionsCommand`
to jav
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1448178059
@mimaison New classes moved to tools.
Please, share your opinion - should I continue work on this task and move
task logic to java?
Or we will merge current changes and then mov
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1438344033
> We can create the new Java classes in tools and not touch the existing
Scala code
Thanks for feedback.
OK. I will move new classes to tools and revert scala code changes m
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1437274047
@mimaison
> I think we should directly move the classes to the tools module instead of
temporarily keeping them in core
Are you suggesting to perform all moving in one PR?
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1432995629
@mimaison Please, share your feedback. Are you ready to review and merge
current changes (only case classes and options moved to java code) or should I
continue work and rewrite the whol
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1431428999
Hello @ijuma
> If you want to do it in small steps
It's more about simplify review then my personal preferences :)
For now, I introduced java classes from `ReassignPa
10 matches
Mail list logo
