[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1645987767 @fvaleri @mimaison Thank you for the review and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1643445734 @mimaison I reworked `parseOffsetJsonStringWithoutDedup` to return `Map>`. Now, Tuple class eliminated from PR. Please, review. -- This is an automated message from the Apache Git

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1642362522 @mimaison all your comments addressed except the one with the Tuple. Please, review. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1641386848 Tests failures unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-164085 @mimaison Thanks for the review. It seems I addressed all your comments. Please, take a look one more time. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1640020567 @fvaleri Done. New tests passed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1629087276 > The JSON parsing logic is shared between multiple tools, including this one, so it seems a nice optimization to have. Sure. We must keep codebase consistent. Anyway, in the

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1628597321 Hello, @fvaleri Thanks for the feedback. > Can you please rebase and add a unit test for the various options, like we have for the other tools? Yes. I merged trunk