nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-704718666
ha - thank you
This is an automated message from the Apache Git Service.
To respond to the message, please log
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-704543777
@ableegoldman @hachikuji - Should I rebase these changes off of trunk
(assuming these tests are fixed on trunk) ?
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-702794731
@hachikuji @ableegoldman - I've added a test for the same exception. Can you
pls take a look and let me know if any changes are needed?
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-699364431
>
>
> @ableegoldman I agree it would be useful to have a test case. If you have
time, maybe you can help out in a follow-up?
@hachikuji @ableegoldman - I'm so sorry
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691464378
@ableegoldman - you're right. I've missed out the license header. I'll also
add the tests for the change. thank you
nym3r0s commented on pull request #9280:
URL: https://github.com/apache/kafka/pull/9280#issuecomment-691058386
@mjsax @ableegoldman @hachikuji - tagging for awareness.
This is an automated message from the Apache Git