[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298325937 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-14 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1293480410 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +847,75 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-14 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1293243166 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +847,75 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-09 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1289107179 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -165,10 +112,11 @@ object DelegationTokenManager { class DelegationTokenManager(val config:

[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-09 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1289096459 ## core/src/test/scala/integration/kafka/api/DelegationTokenEndToEndAuthorizationTest.scala: ## @@ -145,12 +163,12 @@ class DelegationTokenEndToEndAuthorizationTest