[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1340690791 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -106,7 +127,62 @@ public void onFailure(RuntimeException e) { return

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1340402407 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Deserializers.java: ## @@ -75,4 +75,12 @@ public void close() { throw new KafkaExcep

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339158811 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventHandler.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339158103 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -17,146 +17,195 @@ package org.apache.kafka.clients

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1339157715 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1338973379 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -330,7 +343,7 @@ private Map prepareCloseFetchSession

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1338972414 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -92,6 +88,23 @@ public AbstractFetch(final LogContext logContext,

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1333739561 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java: ## @@ -141,11 +77,25 @@ public T addAndGet(final CompletableApplicati

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1333616692 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -259,17 +144,41 @@ long handlePollResult(NetworkClientDelegat

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r155626 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r153596 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -79,6 +100,7 @@ public void clearBufferedDataForUnassignedPartitions(Collect

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r153029 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r149057 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ErrorEventHandler.java: ## @@ -22,13 +22,18 @@ import java.util.Queue; public class ErrorEven

[GitHub] [kafka] philipnee commented on a diff in pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch request manager

philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r145949 ## checkstyle/import-control.xml: ## @@ -205,6 +205,10 @@ + Review Comment: is the extra line intentional? -- This is an automated message fro