[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-21 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1646161376 Hey @junrao - Thanks again. I updated the description to reflect the updated code more accurately. Here I just quoted the paragraph I made the change to: ``` We will explicitly

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-20 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1644739179 Thanks, @junrao -The failing tests should be fixed in the latest commit: The integration test failed because of missing subscription state dependency, which was added in one of the

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-19 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1642545962 @junrao - thanks for the review. I've addressed the two issues you pointed out. Would you be able to take another look at it? -- This is an automated message from the Apache Git

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-06 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1623905234 @kirktrue thanks for taking over this. @junrao - would you be up for another round of review? -- This is an automated message from the Apache Git Service. To respond to the message,