[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-03-03 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1453878000 I've added the MetadataVersion fixes with tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-03-01 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1450839352 > We need a test like `./metadata/src/test/java/org/apache/kafka/image/ScramImageTesst.java` , similar to the tests for the other Image classes. I'm confused by this comment. T

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-02-08 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1422710574 I plan to update existing tests after bootstrap support is committed. I'll check on the `handleDescribeUserScramCredentialsRequest` -- This is an automated message from th

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-01-31 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1411037660 I just updated AlterUserScramCredentialsRequestTest to work in KRaft after finding it while looking into the tests you wanted. It covers a lot of what you want testing ScramControlMan

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-01-30 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1408812047 > The changes to `BrokerMetadataSnapshotterTest.scala` are needed and small. The size of the SCRAM records is larger than 1024 bytes and so I increased it to 4096 bytes in the