[GitHub] [kafka] pprovenzano commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-28 Thread via GitHub
pprovenzano commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1695736206 > DelegationTokenEndToEndAuthorizationWithOwnerTest I created https://issues.apache.org/jira/browse/KAFKA-15411 and will start looking at it today. -- This is an automated me

[GitHub] [kafka] pprovenzano commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-15 Thread via GitHub
pprovenzano commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1679832173 > I think this starts to look good. There are some parts I haven't reviewed yet, I'll try to get them in the next few days. Thank you for the review comments. I think I have add

[GitHub] [kafka] pprovenzano commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-15 Thread via GitHub
pprovenzano commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1679827453 > @pprovenzano Thanks for the PR. left few comments > > can we also update delegation token docs if required (like any configs for controller nodes etc..) https://github.com/ap

[GitHub] [kafka] pprovenzano commented on pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-07-26 Thread via GitHub
pprovenzano commented on PR #14083: URL: https://github.com/apache/kafka/pull/14083#issuecomment-1651985826 > I just took a quick look and I can see multiple protocol change, quite a big refactor to make it working with KRaft and it feels like we should write a KIP about this. What do you t