[GitHub] [kafka] rajinisivaram commented on a diff in pull request #12954: KAFKA-14352: Rack-aware consumer partition assignment protocol changes (KIP-881)

2022-12-06 Thread GitBox
rajinisivaram commented on code in PR #12954: URL: https://github.com/apache/kafka/pull/12954#discussion_r1040687385 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -245,7 +248,8 @@ protected JoinGroupRequestData.JoinGroupReq

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #12954: KAFKA-14352: Rack-aware consumer partition assignment protocol changes (KIP-881)

2022-12-06 Thread GitBox
rajinisivaram commented on code in PR #12954: URL: https://github.com/apache/kafka/pull/12954#discussion_r1040685932 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractPartitionAssignor.java: ## @@ -47,23 +51,37 @@ public abstract class AbstractPartitio