[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-11 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1180354994 After discussing with @skaundinya15 offline, I have rebased and made some changes to the PR to get it ready to merge into 3.3. -- This is an automated message from the Apache Git

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1182845981 @dajac Thanks for the review and the great suggestions. I have updated the PR, please take another look, thank you! -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1183439218 @dajac Thanks for the review, I have addressed all the comments except the additional unit test. Will it be ok if that is added in a follow-on PR? I need to figure out how to make t

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-13 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1183710977 @dajac Thanks for the reviews, I have addressed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] rajinisivaram commented on pull request #10964: KAFKA-13043: Implement Admin APIs for offsetFetch batching

2022-07-14 Thread GitBox
rajinisivaram commented on PR #10964: URL: https://github.com/apache/kafka/pull/10964#issuecomment-1184403492 @dajac Thanks for the reviews and changes. Merging to trunk and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub