rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-635846684
@ijuma @chia7712 Thanks for the reviews, merging to trunk and 2.5.
This is an automated message from the Apa
rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-635224994
@ijuma Thanks for the review, have addressed the comments.
This is an automated message from the Apache Git
rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-634769086
@ijuma Based on our discussion, I have added
`Selector#clearCompletedSends()` and `Selector#clearCompletedReceives()` for
SocketServer to clear buffers after they are proces
rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-633934633
@ijuma By not updating `completedReceives` when the channel is closed, we
retain a reference to the channel until the next `poll()`. In terms of receives
themselves, there i
rajinisivaram commented on pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#issuecomment-632241769
@chia7712 I was tempted to do that initially, but that is not the pattern we
use for everything else in Selector and it has always been this way (for
several years), so addi
