[GitHub] [kafka] rhauch commented on pull request #8134: KAFKA-9546 Allow custom tasks through configuration

2020-09-29 Thread GitBox
rhauch commented on pull request #8134: URL: https://github.com/apache/kafka/pull/8134#issuecomment-700796780 Thanks for the PR, @gcsaba2. However, I'm going to close this per my comments on https://issues.apache.org/jira/browse/KAFKA-9546. TLDR; the `FileStreamSourceConnector`

[GitHub] [kafka] rhauch commented on pull request #8134: KAFKA-9546 Allow custom tasks through configuration

2020-09-28 Thread GitBox
rhauch commented on pull request #8134: URL: https://github.com/apache/kafka/pull/8134#issuecomment-700351105 As noted on https://issues.apache.org/jira/browse/KAFKA-9546, I'm not convinced this is useful change, since it would complicate these example connectors that ship with AK and