[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642360742 @C0urante the original description doesn't mention that the task metrics for a failed task will also be removed when the connector is deleted (in addition to the worker stopping

[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642339479 One concern I have is that we're not actually verifying in any of the tests that the task metrics are cleaned up when a connector is deleted, and that the tasks that remain after

[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-09 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-641686831 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-05 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-639726107 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-05-23 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-633060086 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to