[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-10-02 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-702745660 No green jobs, but all of the Connect and MirrorMaker2 tests in all of the jobs passed. All of the failures in the tests were (flaky) client, broker, or streams tests.

[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-10-01 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-702447474 @shaikzakiriitm I added another test to verify that having a null within a JSON field is not a problem. It builds for me locally, and the new test passes when I've tested it

[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-10-01 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-702443976 Thanks for putting together this comprehensive list of AK versions, Jackson versions, and behavior. > * ak v2.3.0 -> j v2.9.9 [Looks like an outlier, where ak version

[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-09-28 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-700182723 @shaikzakiriitm, you mentioned above: > From v2.10.0 onwards, in jackson lib, ObjectMapper.readTree(input) started to return JsonNode of type MISSING for empty input, as