[GitHub] [kafka] rhauch commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-03-02 Thread GitBox
rhauch commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-789100759 If we don't clarify the documentation, then I think users will be very confused. Can you take a stab at improving/expanding the documentation a bit to clarify the input and output

[GitHub] [kafka] rhauch commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-26 Thread GitBox
rhauch commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-786911483 The documentation is auto-generated from the code, via [TransformationDoc](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/tools/Tr

[GitHub] [kafka] rhauch commented on pull request #9950: KAFKA-12170: Fix for Connect Cast SMT to correctly transform a Byte array into a string

2021-02-22 Thread GitBox
rhauch commented on pull request #9950: URL: https://github.com/apache/kafka/pull/9950#issuecomment-783634110 Before this fix, the changes made in #4820 ([KAFKA-6684](https://issues.apache.org/jira/browse/KAFKA-6684)) resulted in `toString()` being called on `byte[]` and `ByteBuffer`. As h