[GitHub] [kafka] riedelmax commented on pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-09-05 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1706895064 @dajac Thank you for the review. I added unit tests and corrected the nits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] riedelmax commented on pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-17 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1682236535 Right now the method does almost nothing.. I could strip it down to this version, which is enough to make tests pass: ``` def handleConsumerGroupDescribe(request:

[GitHub] [kafka] riedelmax commented on pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-11 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1675067780 Hey @jeffkbkim I fixed the related test failures. I had to implement some lines in KafkaApis::handleConsumerGroupDescribe to make it work. However, this is still a mess as the real

[GitHub] [kafka] riedelmax commented on pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-09 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1671187508 I will find time in the next days to fix those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] riedelmax commented on pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-03 Thread via GitHub
riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1663490350 @jeffkbkim thank you for your comments. I updated the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the