[GitHub] [kafka] rondagostino commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag

2020-09-14 Thread GitBox
rondagostino commented on pull request #9274: URL: https://github.com/apache/kafka/pull/9274#issuecomment-692271106 @cmccabe There were several test failures at first, so I pushed commit https://github.com/apache/kafka/pull/9274/commits/fb417ade01613dad8fa2574c4ea3484f3fa4e65f to fix them

[GitHub] [kafka] rondagostino commented on pull request #9274: KAFKA-10131: Remove use_zk_connection flag

2020-09-09 Thread GitBox
rondagostino commented on pull request #9274: URL: https://github.com/apache/kafka/pull/9274#issuecomment-689862257 @cmccabe Thanks for the review. I put the logic back into `kafka_acls.py`. Take a look and let me know if this is what you were thinking.