[GitHub] [kafka] ryannedolan commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2021-01-26 Thread GitBox
ryannedolan commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-767570251 > I have a preference for your first suggestion ... because it doesn't alter the behavior of MM2 in any way for existing users. Good point, and also it doesn't conflict

[GitHub] [kafka] ryannedolan commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-27 Thread GitBox
ryannedolan commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-735039590 What if we just run herders in both directions (A->B and B->A) whenever replication is enabled in one or both directions? That would require very minimal code changes, and onl

[GitHub] [kafka] ryannedolan commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-20 Thread GitBox
ryannedolan commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-731307334 > Looking into my configuration, I now understand that I was lucky because I have one link going up back up replica_OLS->replica_CENTRAL which is now the single emitter of bea

[GitHub] [kafka] ryannedolan commented on pull request #9589: KAFKA-10710 - Mirror Maker 2 - Create herders only if source->target.enabled=true

2020-11-16 Thread GitBox
ryannedolan commented on pull request #9589: URL: https://github.com/apache/kafka/pull/9589#issuecomment-728354718 > The code seems to explicitly allow the connector to be created even when the link is disabled. > @ryannedolan maybe you could clarify? My intention was to ensure th