[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-830002056 Thanks @kowshik for your comments. Addressed with replies, updated the PR with commit https://github.com/apache/kafka/pull/10271#discussion_r623771771 -- This is an automated

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-827811882 Thanks @junrao for the comments. Fixed checkstyle in raft module and added a comment in `RemoteLogMetadataSerde`. -- This is an automated message from the Apache Git

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-827691407 @junrao Thanks for the review comments. Addressed them with the commit https://github.com/apache/kafka/pull/10271/commits/44cb1f374701cc6eca5d1df19dc9cd7c14497b3e -- This is

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-826991751 @junrao: I will have a followup PR for moving `RecordSerde`, `AbstractApiMessageSerde`, `BytesApiMessageSerde` into clients modules as I discussed earlier. -- This is an

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-826988567 Thanks @junrao for the review. Addressed them with the inline replies, and with the commit

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-821960939 Thanks @junrao for your comments. Addressed them with commit [e909c7f](https://github.com/apache/kafka/pull/10271/commits/e909c7fc481945e54b7e364d2f52c9d191f988ec). -- This

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-821008456 Thanks @junrao for the review. Addressed your comments in commit [1973eda](https://github.com/apache/kafka/pull/10271/commits/1973eda32071797b8a0f090cfba9508086ae1510). --

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-820438379 @junrao This PR is rebased with the latest trunk and it is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-820437818 Thanks @kowshik for the review. Addressed them with the latest [5250b79](https://github.com/apache/kafka/pull/10271/commits/5250b79cef6d21c73d2b2a12ef7cd95a00e9f034). -- This

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-804975395 @kowshik Classes introduced in this PR are located in the new module created as part of https://github.com/apache/kafka/pull/10218. You can omit the first 2 commits and review

[GitHub] [kafka] satishd commented on pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

satishd commented on pull request #10271: URL: https://github.com/apache/kafka/pull/10271#issuecomment-791545987 @junrao This is an automated message from the Apache Git Service. To respond to the message, please log on to